Code
  1. Code
  2. CODE-1744

PREFEAT:Weapon Specialization (TYPE=Piercing.Melee) not working

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Minor Minor
    • Resolution: Cancelled
    • Affects Version/s: 5.17.19
    • Fix Version/s: None
    • Component/s: None
    • Environment:
      JRE 1.6

      Description

      Need to be able to match only on a weapon specialization that matches all given types.

        Issue Links

          Activity

          Hide
          Brad Kester
          added a comment -

          Alright, I'll do this tomorrow, Friday the 12th, around 10:00am CST. Just so you know when I'll be in the files

          Show
          Brad Kester
          added a comment - Alright, I'll do this tomorrow, Friday the 12th, around 10:00am CST. Just so you know when I'll be in the files
          Hide
          James Dempsey
          added a comment -

          I'm a little surprised that the type is checking only the equipment type and not the proficiency type. That probably dates back to when weapon proficiencies were not full objects. Can you see any negative side-effects of adding checking of the proficiency to the TYPE processing?

          Show
          James Dempsey
          added a comment - I'm a little surprised that the type is checking only the equipment type and not the proficiency type. That probably dates back to when weapon proficiencies were not full objects. Can you see any negative side-effects of adding checking of the proficiency to the TYPE processing?
          Hide
          Brad Kester
          added a comment -

          While I know this comment was directed at Andrew, my first thought was "Well, only if proficiencies will have TYPE's that shouldn't be in EquipmentType." I could run a script to compare all the TYPEs from the equipment and their respective proficiency TYPE's, but it'd have to be tomorrow. :/

          Show
          Brad Kester
          added a comment - While I know this comment was directed at Andrew, my first thought was "Well, only if proficiencies will have TYPE's that shouldn't be in EquipmentType." I could run a script to compare all the TYPEs from the equipment and their respective proficiency TYPE's, but it'd have to be tomorrow. :/
          Hide
          Andrew Maitland
          added a comment -

          I don't see any negative. Most of them are duplicated. It's always been a little confusing which bonus looks where or prexxx checks against something else. I'd have no problem with it looking at both.

          Show
          Andrew Maitland
          added a comment - I don't see any negative. Most of them are duplicated. It's always been a little confusing which bonus looks where or prexxx checks against something else. I'd have no problem with it looking at both.
          Hide
          James Dempsey
          added a comment -

          Completed in CODE-1747

          Show
          James Dempsey
          added a comment - Completed in CODE-1747

            People

            • Assignee:
              James Dempsey
              Reporter:
              Brad Kester
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: