PREFEAT:Weapon Specialization (TYPE=Piercing.Melee) not working

The dot syntax in your type specification is not valid for PREreqs on types, so it is looking for a single type named Piercing.Melee

Something like PREFEAT:2,Weapon Specialization (TYPE=Piercing),Weapon Specialization (TYPE=Melee) will get close.

That's has the propensity of hitting on false positives. It'd need to be something more like PREFEAT:1,Weapon Specialization (TYPE=Piercing, TYPE=Melee). The hit needs to occur on a single weapon that is both piercing and melee.

No, reread the syntax... You must have Both. It comes out the same.

PREFEAT:2, < note the '2' which mean BOTH qualifiers must be met.

I saw the 2. The problem is that if I take two feats of Weapon Specialization and one is a melee slashing and another is ranged piercing, they would hit on this qualifier. And they shouldn't. I just tested it on Weapon Specialization (Battleaxe) and Weapon Specialization (Crossbow (Light)). That configuration shouldn't allow the user to take Impaling Critical, but with that setup, they can.

Sadly that is a Feature Request. I know I had MeleePiercing in the rsrd set, that might have been used in PF, if not, that would be the way to go.

Yes, MeleePiercing is a valid type, same as MeleeSlashing, and MeleeBludgeoning.

Use that. Cheers,

I don't know the internals of what the profs_weapons file does exactly, but that is where the MeleePiercing, etc are located. This does not seem to translate to the weapons in regards to determining if Focus/Specialization feats meet the prerequisites. I changed the feat so its Specialization used MeleePiercing as the TYPE, and it never hits on any weapons that have the MeleePiercing TYPE in the profs_weapons file. Tested against Pick (Light) and Rapier.

It must be testing against EquipmentType and not ProficiencyType. I'll attach a MeleePiercing to the Equipment Type for you.

Okay, update to the latest version and test against the Light Pick and Rapier. See if that works.

It works. Seems like a lot of work, though, for a stopgap fix. I mean, in the short term it will do the job,but it'll require that all weapons are updated to include the appropriate Melee or Ranged and damage type into their Equipment Types. And, that'll have to be added for all data sets. While the coding side of it is more complicated, allowing for multiple AND types would be future friendly and not require changes to the data to work properly. I guess that's really something for James to decide, ja?

You have the HandWave from me to Alter all the weapons to handle this need - I'd recommend just doing the MeleePiercing and see where James stands on the two new requests you'll open. Open a NEWTAG Feature Request to allow Chaining Together TYPE; you'll also want a Second NEWTAG Modify for a New version 'PROFTYPE=x' PROFTYPE= would examine the Weapon Prof TYPE of the Weapon. If that was working we would have to change the weapons.

Alright, I'll do this tomorrow, Friday the 12th, around 10:00am CST. Just so you know when I'll be in the files

I'm a little surprised that the type is checking only the equipment type and not the proficiency type. That probably dates back to when weapon proficiencies were not full objects. Can you see any negative side-effects of adding checking of the proficiency to the TYPE processing?

While I know this comment was directed at Andrew, my first thought was "Well, only if proficiencies will have TYPE's that shouldn't be in EquipmentType." I could run a script to compare all the TYPEs from the equipment and their respective proficiency TYPE's, but it'd have to be tomorrow. :/

I don't see any negative. Most of them are duplicated. It's always been a little confusing which bonus looks where or prexxx checks against something else. I'd have no problem with it looking at both.

Completed in CODE-1747