Code
  1. Code
  2. CODE-188

CL not being evaluated on SUBCLASS Levels greater than Level 1

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 5.16.3 RC1
    • Fix Version/s: 5.16.3
    • Component/s: Formula Term
    • Labels:
      None

      Description

      MSRD -

      Create any base class to level 2 or higher, the class feat granted at 2nd and every even level won't appear.

      Now, if you edit the file to change the Level 2 line to Level 1 line, then the class feat appears. Code seems to ignore any level beyond 1st.

        Activity

        Hide
        Andrew Maitland
        added a comment -

        Tested all the way back to 5.16.0 and it's affecting back to there. I don't have a copy of 5.14 currently to see if this touches that.

        Show
        Andrew Maitland
        added a comment - Tested all the way back to 5.16.0 and it's affecting back to there. I don't have a copy of 5.14 currently to see if this touches that.
        Hide
        James Dempsey
        added a comment -

        Tested with a human tough hero. Sources loaded were msrd basics, msrd modern. Saw that the Tough Feats pool advanced to 1 on attaining second level when using 5.14, but did not advance when using 5.16.3 RC3

        Show
        James Dempsey
        added a comment - Tested with a human tough hero. Sources loaded were msrd basics, msrd modern. Saw that the Tough Feats pool advanced to 1 on attaining second level when using 5.14, but did not advance when using 5.16.3 RC3
        Hide
        James Dempsey
        added a comment -

        Subject: [pcgen] Re: [Trackered] MSRD heroic classes...
        Date: Tue, 27 Jul 2010 17:55:41 -0000
        From: thpr
        To: pcgen@yahoogroups.com

        There are 2 possibilities:

        (1) There is a formula resolution that takes place where the proper source is not provided (called many different places and will be specific to the usage in the data)

        (2) There is a way to get a PCClassLevel not loaded with the proper source (originated in the PCClass) (would be in a few focused places, and effectively shared across all usages of tokens in class levels)

        I find (1) more likely given that the test suite character works, so we'll need to know precisely where the formula is that is a problem (what location/token does it appear in)

        TP.

        — In pcgen@yahoogroups.com, Andrew Wilson <andrew@...> wrote:
        >
        > I'd bet it's passing the wrong source into the formula creation, and since it
        > can't figure out which class you want it to evaluate for it returns zero.
        >
        > andrew

        Show
        James Dempsey
        added a comment - Subject: [pcgen] Re: [Trackered] MSRD heroic classes... Date: Tue, 27 Jul 2010 17:55:41 -0000 From: thpr To: pcgen@yahoogroups.com There are 2 possibilities: (1) There is a formula resolution that takes place where the proper source is not provided (called many different places and will be specific to the usage in the data) (2) There is a way to get a PCClassLevel not loaded with the proper source (originated in the PCClass) (would be in a few focused places, and effectively shared across all usages of tokens in class levels) I find (1) more likely given that the test suite character works, so we'll need to know precisely where the formula is that is a problem (what location/token does it appear in) TP. — In pcgen@yahoogroups.com, Andrew Wilson <andrew@...> wrote: > > I'd bet it's passing the wrong source into the formula creation, and since it > can't figure out which class you want it to evaluate for it returns zero. > > andrew
        Hide
        James Dempsey
        added a comment -

        Subject: Re: [pcgen] Re: [Trackered] MSRD heroic classes...
        Date: Tue, 27 Jul 2010 11:04:00 -0700 (PDT)
        From: Andrew Maitland
        To: pcgen@yahoogroups.com

        Tom,

        I specifically tested the same character twice - rebuilt the same way:

        SUBCLASSLEVEL:2 <> BONUS:ABILITYPOOL|Blah|CL/2

        Would not work

        Change that to
        SUBCLASSLEVEL:1 <> BONUS:ABILITYPOOL|Blah|CL/2
        And it works. It very much seems to directly relate to the SubClass structure.
        Whether it's directly tied to CL or anything I can't say. It's baffling me as
        well. I haven't tried changing it to a straight number.

        Show
        James Dempsey
        added a comment - Subject: Re: [pcgen] Re: [Trackered] MSRD heroic classes... Date: Tue, 27 Jul 2010 11:04:00 -0700 (PDT) From: Andrew Maitland To: pcgen@yahoogroups.com Tom, I specifically tested the same character twice - rebuilt the same way: SUBCLASSLEVEL:2 <> BONUS:ABILITYPOOL|Blah|CL/2 Would not work Change that to SUBCLASSLEVEL:1 <> BONUS:ABILITYPOOL|Blah|CL/2 And it works. It very much seems to directly relate to the SubClass structure. Whether it's directly tied to CL or anything I can't say. It's baffling me as well. I haven't tried changing it to a straight number.
        Hide
        James Dempsey
        added a comment -

        Works correctly in trunk. Also tested with an integer value and it works correctly in the 5.16 branch code.

        Show
        James Dempsey
        added a comment - Works correctly in trunk. Also tested with an integer value and it works correctly in the 5.16 branch code.
        Hide
        James Dempsey
        added a comment -

        Sub class name was not being linked to the character's class when calculating the class level.

        Show
        James Dempsey
        added a comment - Sub class name was not being linked to the character's class when calculating the class level.

          People

          • Assignee:
            James Dempsey
            Reporter:
            Andrew Maitland
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: