[Pathfinder] Druid Domain non-functional

Note a workaround is available - see DATA-33

Downgrade from Major to Minor based on available workaround

On level up some data is set for domains, but only where a domain is currently available. This is why it will work at second level but not at first. Further investigation is neded into if this needs to be conditional, or if it can be done at another time that level up.

In case this helps debug this, in 5.17.5, when adding the druid domain the following shows up in the console:

Exception in thread "AWT-EventQueue-0" java.lang.IllegalArgumentException: Source may not be null
at pcgen.cdom.facet.AbstractSingleSourceListFacet.add(AbstractSingleSourceListFacet.java:71)
at pcgen.core.PlayerCharacter.addDomain(PlayerCharacter.java:12220)
at pcgen.core.PlayerCharacter.addDomain(PlayerCharacter.java:12215)
at pcgen.gui.tabs.InfoDomain.selectDomainIndex(InfoDomain.java:1437)
at pcgen.gui.tabs.InfoDomain.access$1100(InfoDomain.java:158)
at pcgen.gui.tabs.InfoDomain$6.actionPerformed(InfoDomain.java:1007)
at javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
at javax.swing.DefaultButtonModel.setPressed(Unknown Source)
at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(Unknown Source)
at java.awt.AWTEventMulticaster.mouseReleased(Unknown Source)
at java.awt.Component.processMouseEvent(Unknown Source)
at javax.swing.JComponent.processMouseEvent(Unknown Source)
at java.awt.Component.processEvent(Unknown Source)
at java.awt.Container.processEvent(Unknown Source)
at java.awt.Component.dispatchEventImpl(Unknown Source)
at java.awt.Container.dispatchEventImpl(Unknown Source)
at java.awt.Component.dispatchEvent(Unknown Source)
at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
at java.awt.Container.dispatchEventImpl(Unknown Source)
at java.awt.Window.dispatchEventImpl(Unknown Source)
at java.awt.Component.dispatchEvent(Unknown Source)
at java.awt.EventQueue.dispatchEvent(Unknown Source)
at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.run(Unknown Source)

In PCClass.addLevel at line 1177 is the following code. This would need to expanded to support the druid domains, most likely by being replicated when the domain is added. The code isn't triggered for a druid as the domain is added later via an ability IIRC.

// Make sure that if this Class adds a new domain that
// we record where that domain came from
final int dnum = aPC.getMaxCharacterDomains(this, aPC) - aPC.getDomainCount();

if (dnum > 0 && !aPC.hasDefaultDomainSource())

I've corrected this to a point. When you select the Druid Domain ability, the UI tracking of domains is updated to reflect that the character has 1 domain to choose. The user then chooses an ability from the druid domain category and then they can select the same domain on the domains tab.

As a suggestion, can the druid domain ability category be discarded and the prereqs on the domains be keyed by the Druid Domain ability instead. Then there is one less step to select the domain, and the domain selection is done on the domains tab.

Please explain the process you think this would work. As I understand it, Domains are trickier for Non-Clerics and the method used was the only method to grant a Domain.

I'm thinking your idea through. It seems there would be more work, cause placing a PRExxx on a domain directly, you'd need to be careful not to break any other class that uses domains. Unless you are suggesting setting up a domain exclusively for Druids, which would be away from Clerics. So as to not risk breaking anything.

That would only change the DOMAIN being granted on the Class Level Lines from using PRExxx, and pushing the PRExxx into exclusive domains. Not sure the trade off is any better.

Could you change the druid class line (and its siblings)
1 DOMAIN:Air[PREABILITY:1,CATEGORY=Special Ability,Druid Domain ~ Air]
to
1 DOMAIN:Air[PREABILITY:1,CATEGORY=Special Ability,Druid Domain]
and eliminate the need to select Druid Domain ~ Air ?

Completed: At revision: 17273 - Core Book

Completed: At revision: 17274 - APG

Find search for 'PREABILITY:1,CATEGORY=Special Ability,Druid Domain ~' turns up nothing else in the repository.