Code
  1. Code
  2. CODE-971

BONUS:COMBAT|AC|Shield|TYPE=Touch.REPLACE does not work

    Details

    • Type: New Feature New Feature
    • Status: Open Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      SF - ID: 2007816
      Last Update: Settings changed ( thpr )
      Details:

      Message:

      http://tech.groups.yahoo.com/group/PCGenListFileHelp/message/16708

      and Message:

      http://tech.groups.yahoo.com/group/PCGenListFileHelp/message/16710
      ============================
      [TM] Re: How to add Shield bonus to Touch AC

      Open a tracker so this doesn't get lost, please

      — In PCGenListFileHelp@yahoogroups.com, Andrew Maitland
      <drew0500@...> wrote:
      >
      > Can we have a Code monkey investigate this please.
      >
      >
      > ~ Andrew Maitland (LegacyKing)
      > ~ Admin Silverback, PCGen Board of Directors
      > ~ Data Chimp, Tracker Gibbon, Docs Tamarin
      > "Quick-Silverback Tracker Monkey"
      >
      >
      >
      > allencohn wrote:
      > > This doesn't seem to work. But
      > >
      > > BONUS:COMBAT|AC|5|TYPE=TOUCH.REPLACE
      > >
      > > Does work. And I've confirmed that 5 is the character's current
      > > Shield bonus.
      > >
      > > Can you think of any way to replace 5 with some variable that
      > > references the current Shield value?
      > >
      > > Many thanks,
      > > Allen
      > >
      > > — In PCGenListFileHelp@yahoogroups.com, Andrew Maitland
      > > <drew0500@> wrote:
      > >
      > >> Hm,
      > >>
      > >> Try
      > >>
      > >> BONUS:COMBAT|AC|Shield|TYPE=Touch.REPLACE
      > >>
      > >> I'm looking at the miscinfo.lst file in the system where the AC
      > >>
      > > types
      > >
      > >> are defined.
      > >>
      > >> ~ Andrew Maitland (LegacyKing)

      ============================
      [TM] Re: How to add Shield bonus to Touch AC

      Thanks, but that doesn't work when I try it, either.

      I appreciate all the help...I don't yet understand how variables work
      in PCGen.

      Allen

      — In PCGenListFileHelp@yahoogroups.com, Paul Grosse <paul.grosse@...>
      wrote:
      >
      > Why not use var("") ?
      >
      > BONUS:COMBAT|AC|var("Shield")|TYPE=TOUCH.REPLACE
      >
      >
      > Paul Grosse
      Submitted:

      David R. Bender ( papa_drb ) - 2008-07-01 11:02:10 EDT
      Priority:

      Status:

      Resolution:

      Tracker:

      Assigned:

      (admin)
      Category:

      (admin)
      Group:

      (admin)
      Visibility:

      Private
      Response:

      (admin)
      Comment:

      Comments ( 6 )
      Add a comment

      Date: 2009-02-09 14:43:26 EST
      Sender: thprProject Admin & Donor
      Hide

      Ah, thanks for the clarification

      Date: 2009-02-08 21:30:48 EST
      Sender: amaitlandProject Admin
      Hide

      Tom, I think you're missing the point, or we need to open a FREQ.

      The OP wants to use the Bonus based upon the Shield AC to add to the Touch
      AC. The SHIELDACCHECK is a separate variable that is unrelated to the
      Shield AC. That is the AC Check Penalty to Skills.

      So
      BONUS:COMBAT|AC|Whatever the Shield Bonus happens to be|TYPE=Touch

      Is what he is desiring.

      BONUS:COMBAT|AC|SHIELDACCHECK|TYPE=Touch will only result in the AC Check
      Penalty (Always a negative number).

      So, do we not currently have a method for tracking the Shield AC type for
      Bonusing?

      Say like:
      BONUS:COMBAT|AC|ACTYPE=Shield|TYPE=Touch

      Date: 2009-02-08 19:05:44 EST
      Sender: thprProject Admin & Donor
      Hide

      BONUS:COMBAT|AC|SHIELDACCHECK|TYPE=Touch.REPLACE is the proper syntax,
      Shield is not a variable

      Date: 2009-02-08 18:08:30 EST
      Sender: amaitlandProject Admin
      Hide

      I did try this and it worked:
      BONUS:COMBAT|AC|SHIELDACCHECK|TYPE=Touch.REPLACE ACCHECK:-3
      Touch AC became 7

      Date: 2009-02-08 17:59:56 EST
      Sender: amaitlandProject Admin
      Hide

      Tried both:
      BONUS:COMBAT|AC|var("SHIELD")|TYPE=Touch.REPLACE
      and
      BONUS:COMBAT|AC|var("SHIELDACCHECK")|TYPE=Touch.REPLACE

      No change.

      Date: 2009-02-05 15:37:26 EST
      Sender: thprProject Admin & Donor
      Hide

      please test using the variable SHIELDACCHECK vs. just SHIELD

        Activity

        Hide
        John Mazzie
        added a comment -

        I just figured out that you could replace the number with var("ARMOR.SHIELD.EQUIPPED.0.ACBONUS"). This will give you the number of the currently equipped shield's AC bonus.

        Thanks,
        John

        Show
        John Mazzie
        added a comment - I just figured out that you could replace the number with var("ARMOR.SHIELD.EQUIPPED.0.ACBONUS"). This will give you the number of the currently equipped shield's AC bonus. Thanks, John
        Hide
        John Mazzie
        added a comment -

        I am having a similar issue with this command, except that when I have BONUS:COMBAT|AC|<number>|TYPE=TOUCH it is adding it in as misc and adding to all AC (Total, Touch, and Flat-footed) and not just increasing Touch AC. I attempted to use the DEFINE:ShieldAddsToTouchAC|<number> but this always adds the full shield bonus when I actually only want part of the bonus to apply.

        I've tested both of these with 5.17.14 Alpha

        Thanks,
        John Mazzie

        Show
        John Mazzie
        added a comment - I am having a similar issue with this command, except that when I have BONUS:COMBAT|AC|<number>|TYPE=TOUCH it is adding it in as misc and adding to all AC (Total, Touch, and Flat-footed) and not just increasing Touch AC. I attempted to use the DEFINE:ShieldAddsToTouchAC|<number> but this always adds the full shield bonus when I actually only want part of the bonus to apply. I've tested both of these with 5.17.14 Alpha Thanks, John Mazzie
        Hide
        Andrew Maitland
        added a comment -

        Find the line in miscinfo.lst

        ACTYPE:Touch ADD:TOTAL REMOVE:Armor|ArmorEnhancement|NaturalArmor|Shield|ShieldEnhancement|NaturalArmorEnhancement ADD:Shield|ShieldEnhancement|PREVARGTEQ:ShieldAddsToTouchAC,1

        See the ADD portion? There are two of them...

        Add 'Touch' to the one with 'TOTAL', and that will solve the issue.

        Show
        Andrew Maitland
        added a comment - Find the line in miscinfo.lst ACTYPE:Touch ADD:TOTAL REMOVE:Armor|ArmorEnhancement|NaturalArmor|Shield|ShieldEnhancement|NaturalArmorEnhancement ADD:Shield|ShieldEnhancement|PREVARGTEQ:ShieldAddsToTouchAC,1 See the ADD portion? There are two of them... Add 'Touch' to the one with 'TOTAL', and that will solve the issue.
        Hide
        John Mazzie
        added a comment -

        With this change to ACTYPE:Touch the value I'm adding to touch is still added to the TOTAL variable. This still causes the Total, Touch and Flat-footed AC to increase, and a double dip on the Touch because I've added to it manually. I attempted to just add the line REMOVE:Touch to this line, but this caused my AC to show up as 0 on the character sheet.

        I worked around this in my miscinfo.lst file just so that it shows correctly on my sheet for now., but the changes aren't intuitive. I've changed ACTYPE:Total from ADD:Total to ADD:<all AC variables included in armor total but with touch removed>. I then had to add REMOVE:Touch to ACTYPE:Flatfooted, ACTYPE:Touch, and ACTYPE:Misc.

        My suggestion for a real fix would be to create a new ACTYPE called TouchEnhancement (similar to the ShieldEnhancement/ArmorEnhancement) but not include it in the TOTAL calculation. This would enable changing ACTYPE:Touch ADD:TOTAL to ADD:TOTAL|TouchEnhancement without affecting any of the other numbers.

        Thanks,
        John

        Show
        John Mazzie
        added a comment - With this change to ACTYPE:Touch the value I'm adding to touch is still added to the TOTAL variable. This still causes the Total, Touch and Flat-footed AC to increase, and a double dip on the Touch because I've added to it manually. I attempted to just add the line REMOVE:Touch to this line, but this caused my AC to show up as 0 on the character sheet. I worked around this in my miscinfo.lst file just so that it shows correctly on my sheet for now., but the changes aren't intuitive. I've changed ACTYPE:Total from ADD:Total to ADD:<all AC variables included in armor total but with touch removed>. I then had to add REMOVE:Touch to ACTYPE:Flatfooted, ACTYPE:Touch, and ACTYPE:Misc. My suggestion for a real fix would be to create a new ACTYPE called TouchEnhancement (similar to the ShieldEnhancement/ArmorEnhancement) but not include it in the TOTAL calculation. This would enable changing ACTYPE:Touch ADD:TOTAL to ADD:TOTAL|TouchEnhancement without affecting any of the other numbers. Thanks, John

          People

          • Assignee:
            Unassigned
            Reporter:
            User Submissions
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated: