New Tag

Export Token [INVALIDTOHIT]

Details

  • Type: New Token New Token
  • Status: In Discussion In Discussion
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: Output Tag
  • Labels:
    None
  • Subtype:
    None Taken

Description

Fix for Post 6.0

Currently we allow the user to change the INVALID TO HIT text. Currently it defaults to 'N/A'. The issue is we have an OS test that requires that exact text or else it breaks the Weapons Output in the Simple Output Sheet.

I propose a New Output token linked to the INVALID TO HIT Text

INVALIDTOHIT

It would export the value entered. We can then make the test check for a value in that token, if yes, then test is valid, if no, proceed.

Issue Links

is required by

Bug - A problem which impairs or prevents the functions of the product. OS-190 2H sword atk/dam reads as null for "simple" exported OS

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Reopened - This issue was once resolved, but the resolution was deemed incorrect. From here issues are either marked assigned or resolved.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Eric C. Smith added a comment -

Would this be a "switch" tag, meaning if it id present it print the invalid tohit text?

Or is the invalid tohit text attached to the tag, i.e. INVALIDTOHIT:Text?

Show
Eric C. Smith added a comment - Would this be a "switch" tag, meaning if it id present it print the invalid tohit text? Or is the invalid tohit text attached to the tag, i.e. INVALIDTOHIT:Text?
Hide
Permalink
Andrew Maitland added a comment -

This tag literally takes the INVALIDTOHIT text value, and places it in the xlst code. Looks like we'll need a tag for INVALIDDAMAGE

Here is a sample:

<xsl:if test="not(w1_h1_p/to_hit = 'null' and w1_h1_p/damage = 'null' and w2_p_oh/to_hit = 'null' and w2_p_oh/damage = 'null')">

null is a value, it's static. Now, change it to

<xsl:if test="not(w1_h1_p/to_hit = 'INVALIDTOHIT' and w1_h1_p/damage = 'INVALIDDAMAGE' and w2_p_oh/to_hit = 'INVALIDTOHIT' and w2_p_oh/damage = 'INVALIDDAMAGE')">

Show
Andrew Maitland added a comment - This tag literally takes the INVALIDTOHIT text value, and places it in the xlst code. Looks like we'll need a tag for INVALIDDAMAGE Here is a sample: <xsl:if test="not(w1_h1_p/to_hit = 'null' and w1_h1_p/damage = 'null' and w2_p_oh/to_hit = 'null' and w2_p_oh/damage = 'null')"> null is a value, it's static. Now, change it to <xsl:if test="not(w1_h1_p/to_hit = 'INVALIDTOHIT' and w1_h1_p/damage = 'INVALIDDAMAGE' and w2_p_oh/to_hit = 'INVALIDTOHIT' and w2_p_oh/damage = 'INVALIDDAMAGE')">

People

  • Assignee:
    Unassigned
    Reporter:
    Andrew Maitland
Vote (0)
Watch (2)

Dates

  • Created:
    Updated: